lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: spin_is_locked() broken for uniprocessor?
    On Wed, 19 Aug 2009 10:38:06 +0100
    David Howells <dhowells@redhat.com> wrote:

    > Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > > > which implies to me that spin_is_locked() will always return false. Is this
    > > > expected behavior.
    > >
    > > That's wrong. spin_is_locked should always return true on UP.
    >
    > Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP.

    That would lead to a lot of

    #ifdef CONFIG_SMP

    #endif

    in drivers because there is driver code that uses spin_is_locked() in
    fairly sensible fashion when dealing with locking.


    \
     
     \ /
      Last update: 2009-08-19 12:55    [W:2.866 / U:0.844 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site