Messages in this thread | | | Subject | Re: [PATCH 3/3] Drop platform sysfs support | From | Marcel Holtmann <> | Date | Tue, 18 Aug 2009 02:54:45 -0700 |
| |
Hi Alan,
> > With rfkill support being added, the platform support is no longer > > necessary. Standard rfkill interfaces can be used to administer the box > > now. > > -- > > Mario Limonciello > > *Dell | Linux Engineering* > > mario_limonciello@dell.com > > > > -static struct platform_device *compal_device; > > I don't think this is the right way to go. I don't object to removing > the sysfs attributes, but the platform device can still be useful as a > parent device to the rfkill and backlight devices. (See my earlier > comment on the use of rfkill_allocate()). > > In practice I suspect it makes no difference that the rfkill and > backlight devices are exported as virtual devices with no physical > parent. I just don't think it's "right" :-).
it actually does make a difference for hardware detection. We wanna have them hanging of the compal platform device.
Regards
Marcel
| |