lkml.org 
[lkml]   [2009]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo'
On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:

> - proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
> + proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);

Style nitpick. The spaces were packed to fit into 80-col I guess.


ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^

ERROR: space required after that ',' (ctx:VxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^

ERROR: space required after that ',' (ctx:VxO)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^

ERROR: space required before that '&' (ctx:OxV)
#10: FILE: mm/slub.c:4729:
+ proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
^

Thanks,
Fengguang


\
 
 \ /
  Last update: 2009-08-18 14:45    [W:0.041 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site