Messages in this thread | | | Date | Thu, 13 Aug 2009 15:29:12 -0700 | From | Greg KH <> | Subject | Re: [patch 28/74] thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM |
| |
On Fri, Aug 14, 2009 at 12:06:43AM +0200, Stefan Lippers-Hollmann wrote: > Hi > > On Thursday 13 August 2009, Greg KH wrote: > > 2.6.30-stable review patch. If anyone has any objections, please let us know. > > > > ------------------ > > > > From: Henrique de Moraes Holschuh <hmh@hmh.eng.br> > > > > commit 59fe4fe34d7afdf63208124f313be9056feaa2f4 upstream. > > > > HBRV-based default selection of backlight control strategy didn't work > > well, at least the X41 defines it but doesn't use it and I don't think > > it will stop there. > > > > Switch to a white/blacklist. All models that have HBRV defined have > > been included in the list, and initially all ATI GPUs will get > > ECNVRAM, and the Intel GPUs will get UCMS_STEP. > > > > Symptoms of incorrect backlight mode selection are: > > > > 1. Non-working backlight control through sysfs; > > > > 2. Backlight gets reset to the lowest level at every shutdown, reboot > > and when thinkpad-acpi gets unloaded; > > > > This fixes a regression in 2.6.30, bugzilla #13826 > > As already reported in [1] and confirmed by hmh in [2], this patch breaks > compiling thinkpad_acpi in 2.6.31-rc5.
My appologies, I forgot to remove this one from the tree. I'll go do so right now.
thanks,
greg k-h
| |