Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 2 Jun 2009 17:48:03 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] usb: avoid PM error messages during resume if a device was disconnected |
| |
On Tue, 2 Jun 2009, Rafael J. Wysocki wrote:
> Returning 0 from usb_external_resume_device() if the device is not present > any more doesn't seem wrong. It's not really an error condition, IMO, because > it's rather normal that the devices may be removed while suspended. > > OTOH, I don't think we can ignore -ENODEV universally in the core, because > its meaning may depend on the bus type. For example, for PCI it sometimes > means a hardware problem has occured (other than the device being not present > any more).
> I'd vote in favor of the Frans' patch, at least for now. > > So, Frans, please resubmit with the changelog modified as requested by Alan.
If we change -ENODEV to 0, the change should be made in usb_resume() rather than usb_external_resume_device().
Alan Stern
| ![\](/images/icornerr.gif) |