lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: epoll_ctl and const correctness
From
Do you read my post? there is a confusion, my question was first : why
the structure isn't const? and you answer me. ok. second, I asked if
the kernel keep track of this structure, that is, it keeps a pointer
on it for doing his job? according to your last answer, no. last
question : why the size type of the first parameter of epoll_create is
int and not size_t? no answer for the moment.

2009/3/27 Michael Tokarev <mjt@tls.msk.ru>:
> nicolas sitbon wrote:
>>
>> I was looking at libevent of niels provos, and even him, is apparently
>> doing a mistake :
>>
>> static int
>> epoll_add(void *arg, struct event *ev)
>> {
>>        struct epollop *epollop = arg;
>>        struct epoll_event epev = {0, {0}};
>>
>>        /* ... some code here ... */
>>        if (epoll_ctl(epollop->epfd, op, ev->ev_fd, &epev) == -1)
>>                        return (-1);
>>
>>        /* Update events responsible */
>>        if (ev->ev_events & EV_READ)
>>                evep->evread = ev;
>>        if (ev->ev_events & EV_WRITE)
>>                evep->evwrite = ev;
>>
>>        return (0);
>> }
>>
>> the structure pointed to by &epev is allocated on the stack, so how
>> the kernel could keep track of it?
>
> I've no idea what are you talking about and what exactly
> is your problem.  Both the examples (one at cplayer.org and
> another above) gives correct usage of epoll.  If you don't
> understand it, well, I'd suggest reading some documentation
> first, maybe in kernel, maybe in glibc, maybe numerous
> available on the net.  And all the numerous examples too,
> which you quote as, for some reason, wrong.
>
> /mjt
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-27 23:59    [W:0.044 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site