lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PULL REQUEST] Quota changes for 2.6.30


On Fri, 27 Mar 2009, Jan Kara wrote:

> On Thu 26-03-09 16:16:47, Linus Torvalds wrote:
> >
> >
> > On Thu, 26 Mar 2009, Jan Kara wrote:
> > >
> > > could you please pull from
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6.git for_linus
> >
> > "Already up-to-date."
> >
> > Forgot to actually push it out?
> Damn, you're right. Should be there now.

It is, but now when I pull I notice that you hadn't used "-M --summary"
when asking me to pull. You claimed:

66 files changed, 4770 insertions(+), 4565 deletions(-)

but in fact it's really:

58 files changed, 902 insertions(+), 697 deletions(-)
create mode 100644 fs/quota/Kconfig
create mode 100644 fs/quota/Makefile
rename fs/{ => quota}/dquot.c (85%)
rename fs/{ => quota}/quota.c (94%)
rename fs/{ => quota}/quota_tree.c (84%)
rename fs/{ => quota}/quota_tree.h (100%)
rename fs/{ => quota}/quota_v1.c (79%)
rename fs/{ => quota}/quota_v2.c (98%)
rename fs/{ => quota}/quotaio_v1.h (100%)
rename fs/{ => quota}/quotaio_v2.h (100%)

so please do change your pull-request script to add -M (for rename
detection) and --summary (for that "new, deleted and renamed files"
summary at the end).

It really does generate a much nicer view of what changed, _especially_ in
cases like the above when a non-rename patch is mostly movement noise.

Git still defaults to non-rename patches because some people probably
still use inferior crud that doesn't understand about the extended patch
semantics of git patches.

Linus


\
 
 \ /
  Last update: 2009-03-27 22:57    [W:0.066 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site