lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds
On Sat, Mar 28, 2009 at 01:16:26AM +1100, Stephen Rothwell wrote:
> > - switch (em->block_start) {
> > - case EXTENT_MAP_LAST_BYTE:
> > + if (em->block_start == EXTENT_MAP_LAST_BYTE) {
>
> I might be a good idea to put a comment there about why this isn't a
> switch statement so that someone doesn't "clean up" this code in the
> future.
>

nrrrgh. Remind me why we can't just add the libgcc helpers?

Unless we plan on growing some more of these, surely we can just reduce
it to a u32 for the switch...

regards, Kyle


\
 
 \ /
  Last update: 2009-03-27 15:27    [W:0.072 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site