Messages in this thread | | | Date | Fri, 27 Mar 2009 13:50:16 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH] iptables: "cluster" match uses IPv6-specific code without ifdef |
| |
Pablo Neira Ayuso wrote: > Patrick McHardy wrote: >> Pablo Neira Ayuso wrote: >>> Steven Noonan wrote: >>>> The symbol __ipv6_addr_type is only available with CONFIG_IPV6 or >>>> CONFIG_IPV6_MODULE. >>> Please, CC netfilter-devel for netfilter-related issues. Patrick, I'm >>> fine with this, can you apply this patch? >> Is my reading correct that this won't introduce a module >> dependency on IPv6? > > Hm, this fixes a compilation issue when IPv6 is not enabled. In that > case you can still use the cluster match, so I don't see any extra > modules dependencies.
That was badly phrased, sorry. The patch of course doesn't change anything in that regard.
I'm wondering whether we have a (runtime) dependency on the ipv6 module due to the ipv6_addr_type() call. If that's the case, it would need to be fixed as well.
| |