Messages in this thread | | | Date | Fri, 27 Mar 2009 17:34:42 +0800 | From | Lai Jiangshan <> | Subject | Re: [PATCH 2/2] Fix wrong format string iter for printk |
| |
Zhaolei wrote: > printk("%Q"); > Output before patch: > %QQ > Output after patch: > %Q > > Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com> > --- > lib/vsprintf.c | 16 ---------------- > 1 files changed, 0 insertions(+), 16 deletions(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 908dd41..b56f6d0 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1062,13 +1062,6 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) > if (str < end) > *str = '%'; > ++str; > - if (*fmt) { > - if (str < end) > - *str = *fmt; > - ++str; > - } else { > - --fmt; > - } > break; > > case FORMAT_TYPE_NRCHARS: { > @@ -1356,8 +1349,6 @@ do { \ > break; > > case FORMAT_TYPE_INVALID: > - if (!*fmt) > - --fmt; > break; > > case FORMAT_TYPE_NRCHARS: { > @@ -1544,13 +1535,6 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf) > if (str < end) > *str = '%'; > ++str; > - if (*fmt) { > - if (str < end) > - *str = *fmt; > - ++str; > - } else { > - --fmt; > - } > break; > > case FORMAT_TYPE_NRCHARS:
It's nice. Review-by: Lai Jiangshan <laijs@cn.fujitsu.com>
| |