Messages in this thread | | | Date | Sat, 14 Feb 2009 17:32:37 -0500 | From | Andres Salomon <> | Subject | Re: [PATCH] olpc: fix model detection without OFW |
| |
On Sat, 14 Feb 2009 23:14:29 +0100 Ingo Molnar <mingo@elte.hu> wrote: [...] > Where did my git grepping skills go wrong? > > I git-grepped the code and this is the scope i found: > > olpc_platform_info.boardrev is used for: > > - a printk > - olpc_board_at_least() which is used in: > - drivers/input/mouse/hgpk.c: mouse driver quirk > - sound/pci/cs5535audio/cs5535audio_olpc.c: audio quirk > > aha. I missed this roundabout impact: > > - arch/x86/kernel/olpc.c: OLPC_F_DCON flag > - which is used in olpc_has_dcon(), which is used in: > - drivers/video/geode/gxfb_core.c: GX modes db > [ouch if this goes > wrong!] > - drivers/video/geode/lxfb_core.c: ditto > > So i guess the mouse and audio quirk point was correct too, but the > major impact is the graphics mode array mismatch and the resulting > nonsensical mode setting, right? > > Ingo
Yep.
| |