Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 9 Dec 2009 09:34:37 +0100 | From | Michał Mirosław <> | Subject | Re: [PATCH 3/7] mtrr: Remove use_intel() |
| |
On Wed, Dec 09, 2009 at 12:10:50AM -0800, Yinghai Lu wrote: > 2009/12/8 Michał Mirosław <mirq-linux@rere.qmqm.pl>: > > Remove use_intel() and use is_cpu(INTEL) instead. > > > > .use_intel_if is duplicating information already found in .vendor, as > > the only combinations used are: > > generic: use_intel_if == 1, vendor == INTEL > > amd/cyrix/centaur: use_intel_if == 0, vendor != INTEL > > [...] > can you check it with amd64 cpu?
Unfortunately I don't have any AMD machines right now.
Anyway, just to clarify why the change is a functional no-op: use_intel() and is_cpu(X) don't check the detected CPU vendor ID but look into mtrr_ops struct. For 64BIT build this means that use_intel() / is_cpu(INTEL) == true when mtrr_if != NULL, and all other is_cpu() == false because no other implementation could be choosen (amd/cyrix/centaur special cpu features are possible only in 32BIT).
Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |