Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Sun, 06 Dec 2009 15:30:45 -0800 | From | Greg KH <> | Subject | [13/20] fuse: prevent fuse_put_request on invalid pointer |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------ From: Anand V. Avati <avati@gluster.com>
commit f60311d5f7670d9539b424e4ed8b5c0872fc9e83 upstream.
fuse_direct_io() has a loop where requests are allocated in each iteration. if allocation fails, the loop is broken out and follows into an unconditional fuse_put_request() on that invalid pointer.
Signed-off-by: Anand V. Avati <avati@gluster.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- fs/fuse/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1005,7 +1005,8 @@ static ssize_t fuse_direct_io(struct fil break; } } - fuse_put_request(fc, req); + if (!IS_ERR(req)) + fuse_put_request(fc, req); if (res > 0) { if (write) fuse_write_update_size(inode, pos);
| ![\](/images/icornerr.gif) |