Messages in this thread | | | Date | Sun, 06 Dec 2009 11:11:48 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/1] X86: use explicit register name for get/put_user |
| |
On 12/06/2009 01:30 AM, Jiri Slaby wrote: > > I don't know if this could ever cause any problems, but changing > the input to an explicit register ("a") makes it cleaner in my eyes. > There is no need of the back reference. >
It can't: the backreference refers to only the information that is in the register constraint, not to anything else. I really would prefer avoiding any changes to working code that aren't justified, simply because every time we change an asm() we risk tickling a new obscure bug in some old version of gcc.
As such,
Nacked-by: H. Peter Anvin <hpa@zytor.com>
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |