Messages in this thread | | | Subject | Re: [PATCH] scripts/checkpatch.pl: Add warning about leading contination tests | From | Joe Perches <> | Date | Sun, 06 Dec 2009 09:46:16 -0800 |
| |
On Sun, 2009-12-06 at 13:13 +0100, Jean Delvare wrote: > Not fine with me. Placing the binary logic operator at the beginning > of a line can be a deliberate choice, either to make complex binary > expressions more readable, or to avoid long lines. I don't see much > point in banning this style, which BTW is used over 8000 times in the > current kernel tree.
Anyone that thinks that checkpatch is the last word on linux coding style and all of its pronouncements must be followed all the time is simply wrong.
It's not a ban. It's neither a command nor an edict. It's a warning. It's a notice that leading logical continuations are not the preferred style and it can be ignored at will.
I think it's rather like the long line, >80 column warning. There are a whole lot more than 8k long lines in kernel source and no one is suggesting reformatting all of them out of existence.
cheers, Joe
| |