lkml.org 
[lkml]   [2009]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Put trampoline_data into readonly section.
On 12/04/2009 08:47 PM, Rakib Mullick wrote:
> On 12/5/09, H. Peter Anvin<hpa@zytor.com> wrote:
>> On 12/04/2009 08:24 AM, Rakib Mullick wrote:
>>
>> Perhaps the better thing would be to define trampoline_size as an
>> absolute symbol in arch/x86/kernel/trampoline_*.S, especially since it
>> probably generates bad code to subtract two global symbols like that.
>>
> But - trampoline_data is placed into - cpu init readonly data section.
> And we are
> referencing it from non-cpuinit function. ....... so I think the
> problem remains.
> Isn't it ? Or am I missing anything?
>

No, we're not actually referencing it at all. We're just using its
length, whereas in reality we actually have copied the code elsewhere
already.

-hpa


\
 
 \ /
  Last update: 2009-12-05 07:21    [W:0.055 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site