Messages in this thread | | | Date | Mon, 28 Dec 2009 06:27:46 +0530 | From | Balbir Singh <> | Subject | Re: [RFC PATCH] asynchronous page fault. |
| |
* Peter Zijlstra <peterz@infradead.org> [2009-12-27 12:19:56]:
> Your changelog states as much. > > "Even if RB-tree rotation occurs while we walk tree for look-up, we just > miss vma without oops." > > However, since this is the case, do we still need the > rcu_assign_pointer() conversion your patch does? All I can see it do is > slow down all RB-tree users, without any gain.
Don't we need the rcu_assign_pointer() on the read side primarily to make sure the pointer is still valid and assignments (writes) are not re-ordered? Are you suggesting that the pointer assignment paths be completely atomic?
-- Balbir
| |