lkml.org 
[lkml]   [2009]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] parisc: test off by one in sgl_frem() and dbl_frem()
Op 27-12-09 16:30, James Bottomley schreef:
> On Sun, 2009-12-27 at 14:21 +0100, Roel Kluin wrote:
>> With `while (stepcount-- > 0)' stepcount reaches -1 after the loop.
>
> This is true, but seems to be by design

>> - if (stepcount > 0 || Sgl_iszero(opnd1)) {
>> + if (stepcount >= 0 || Sgl_iszero(opnd1)) {

>
> Your patch does nothing to the actual execution flow (Sgl_iszero is true
> if stepcount == 0) ... what's the point of applying it?
>
> James

Ok, please ignore and thanks (also to Dave) for review.

Roel


\
 
 \ /
  Last update: 2009-12-27 22:11    [W:0.086 / U:1.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site