Messages in this thread | | | Date | Sun, 27 Dec 2009 22:11:06 +0100 | From | Roel Kluin <> | Subject | Re: [PATCH] parisc: test off by one in sgl_frem() and dbl_frem() |
| |
Op 27-12-09 16:30, James Bottomley schreef: > On Sun, 2009-12-27 at 14:21 +0100, Roel Kluin wrote: >> With `while (stepcount-- > 0)' stepcount reaches -1 after the loop. > > This is true, but seems to be by design
>> - if (stepcount > 0 || Sgl_iszero(opnd1)) { >> + if (stepcount >= 0 || Sgl_iszero(opnd1)) {
> > Your patch does nothing to the actual execution flow (Sgl_iszero is true > if stepcount == 0) ... what's the point of applying it? > > James
Ok, please ignore and thanks (also to Dave) for review.
Roel
| |