Messages in this thread Patch in this message | | | Date | Fri, 25 Dec 2009 15:36:16 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Kbuild: set LC_MESSAGES=C (as LC_CTYPE=C is) |
| |
On 12/25/2009 09:13 AM, Sergei Trofimovich wrote: > We restricted LC_CTYPE to ASCII recently but not messages from, say, > gcc. So instead of nice warnings I get '???? ??????? ???????' > (ru_RU.UTF-8 locale) as a gcc warning, which is not nice. So, set > LC_MESSAGES=C too.
The whole reason with only setting some LC_* to C was to be able to leave LC_MESSAGES intact, but it seems it breaks on too many real-life systems.
As such, I suggest we should set LC_ALL=C and get rid of the rest of it:
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
From 633dcb9167582064ec5d2d832450e93768cfe376 Mon Sep 17 00:00:00 2001 From: H. Peter Anvin <hpa@zytor.com> Date: Fri, 25 Dec 2009 15:34:33 -0800 Subject: [PATCH] Makefile: Set LC_ALL=C
We were setting LC_CTYPE, LC_COLLATE and LC_NUMERIC to the C locale, with the intent that LC_MESSAGES would still be localized. Unfortunately, that doesn't seem to actually work in real life, so just be done with it and set LC_ALL=C.
Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- Makefile | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile index c628a5c..a801d1d 100644 --- a/Makefile +++ b/Makefile @@ -17,11 +17,8 @@ NAME = Man-Eating Seals of Antiquity MAKEFLAGS += -rR --no-print-directory # Avoid funny character set dependencies -unexport LC_ALL -LC_CTYPE=C -LC_COLLATE=C -LC_NUMERIC=C -export LC_CTYPE LC_COLLATE LC_NUMERIC +LC_ALL=C +export LC_ALL # We are using a recursive build, so we need to do a little thinking # to get the ordering right. -- 1.6.2.5
| |