Messages in this thread | | | Date | Fri, 25 Dec 2009 15:10:48 -0500 | From | tytso@mit ... | Subject | Re: [PATCH] ext4: return correct wbc.nr_to_write in ext4_da_writepages |
| |
On Thu, Dec 17, 2009 at 11:02:32PM +0530, Aneesh Kumar K.V wrote: > On Thu, Dec 17, 2009 at 09:40:25AM -0600, Eric Sandeen wrote: > > Richard Kennedy wrote: > > > ext4: always re-base nr_to_write in ext4_da_writepages > > > > > > When ext4_da_writepages increases the nr_to_write in writeback_control > > > then it must always re-base the return value. > > > > > > Without this change, when wb_writeback calculates how many pages were > > > actually written it can get a negative value and loop more times than > > > necessary. In tests I have seen nearly all the dirty pages pushed out to > > > writeback due to this issue. > > > > > > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Added to the ext4 patch queue, thanks.
- Ted
| |