lkml.org 
[lkml]   [2009]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver
    David Miller wrote:
    > From: Jason Wessel <jason.wessel@windriver.com>
    > Date: Wed, 23 Dec 2009 15:19:28 -0600
    >
    >
    >> +static void sunzilog_put_poll_char(struct uart_port *port,
    >> + unsigned char ch)
    >> +{
    >> + struct uart_sunzilog_port *up = (struct uart_sunzilog_port *)port;
    >> +
    >> + sunzilog_putchar(&up->port, ch);
    >> + udelay(2);
    >> +
    >> +}
    >> +#endif /* CONFIG_CONSOLE_POLL */
    >>
    >
    > Just curious, what is the udelay() for?
    >

    This was copied from zm.c driver. I don't think the HW needs it, I'll
    retest and purge it.

    >
    >> static struct uart_ops sunzilog_pops = {
    >> .tx_empty = sunzilog_tx_empty,
    >> .set_mctrl = sunzilog_set_mctrl,
    >> @@ -1013,6 +1061,10 @@ static struct uart_ops sunzilog_pops = {
    >> .request_port = sunzilog_request_port,
    >> .config_port = sunzilog_config_port,
    >> .verify_port = sunzilog_verify_port,
    >> +#ifdef CONFIG_CONSOLE_POLL
    >> + .poll_get_char = sunzilog_get_poll_char,
    >> + .poll_put_char = sunzilog_put_poll_char,
    >> +#endif
    >> };
    >>
    >
    > Please make the indentation consistent with the rest of those in
    > this structure.
    >

    Consider it done.

    Thanks,
    Jason.


    \
     
     \ /
      Last update: 2009-12-23 22:57    [W:2.977 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site