Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 23 Dec 2009 08:19:32 -0800 | From | Greg KH <> | Subject | Re: [patch 1/7] [patch] DT3155: Use pci_get_device |
| |
On Wed, Dec 23, 2009 at 07:54:49PM +1100, Simon Horman wrote: > The use of pci_find_device() is deprecated. > > Signed-off-by: Simon Horman <horms@verge.net.au> > > --- > > Compile tested only. > > Alternatively, if pci_find_device() really needs to be used > then this code needs to depend on PCI_LEGACY. > > Index: gregkh-2.6/drivers/staging/dt3155/dt3155_drv.c > =================================================================== > --- gregkh-2.6.orig/drivers/staging/dt3155/dt3155_drv.c 2009-12-23 18:41:46.000000000 +1100 > +++ gregkh-2.6/drivers/staging/dt3155/dt3155_drv.c 2009-12-23 18:42:29.000000000 +1100 > @@ -963,7 +963,7 @@ static int find_PCI (void) > unsigned long base; > unsigned char irq; > > - while ((pci_dev = pci_find_device > + while ((pci_dev = pci_get_device
You can't just replace these two functions, they operate differently with regard to the reference counting logic. Otherwise it wouldn't make sense to have 2 different functions :)
So I can't apply this.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |