Messages in this thread Patch in this message | | | From | Uwe Kleine-König <> | Subject | [PATCH] add missing include in lib/rational.c | Date | Tue, 22 Dec 2009 17:11:50 +0100 |
| |
From: Sascha Hauer <s.ha...@pengutronix.de>
This fixes:
lib/rational.c:62: warning: data definition has no type or storage class lib/rational.c:62: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' lib/rational.c:62: warning: parameter names (without types) in function declaration
Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> Acked-by: WANG Cong <xiyou.wangcong@gmail.com> Acked-by: Oskar Schirmer <os@emlix.com> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Andrew Morton <akpm@linux-foundation.org> --- Hi,
Oskar Schirmer wrote: > > lib/rational.c:62: warning: data definition has no type or storage > > class > > lib/rational.c:62: warning: type defaults to 'int' in declaration of > > 'EXPORT_SYMBOL' > > lib/rational.c:62: warning: parameter names (without types) in > > function declaration > > Oh yes, we didnt use it with modules up to now. Note this has nothing to do if the symbol is used in modules or not. It's just that EXPORT_SYMBOL (which publishes the symbol to the module linker). I havn't checked, but I assume the compiler interprets
EXPORT_SYMBOL(rational_best_approximation);
just as declaration of a function EXPORT_SYMBOL and doesn't generate the needed magic to actually export rational_best_approximation.
Best regards Uwe --- lib/rational.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/rational.c b/lib/rational.c index b3c099b..3ed247b 100644 --- a/lib/rational.c +++ b/lib/rational.c @@ -7,6 +7,7 @@ */ #include <linux/rational.h> +#include <linux/module.h> /* * calculate best rational approximation for a given fraction -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |