Messages in this thread | | | Date | Tue, 22 Dec 2009 16:26:59 +0100 | From | Roger Luethi <> | Subject | Re: via_rhine kernel crashes in 2.6.32 |
| |
On Tue, 22 Dec 2009 20:00:45 +0500, Andrey Rahmatullin wrote: > On Tue, Dec 22, 2009 at 01:38:17PM +0000, Jarek Poplawski wrote: > > > > It looks like napi_disable() should be illegal in ndo_tx_timeout(). > > > > Here is a patch which moves most of the timeout work to a workqueue, > > > > similarly to tg3 etc. It should prevent at least one of reported > > > > bugs. Alas I can't even check-compile it at the moment, so let me > > > > know on any problems. > > > It seems I needlessly changed locking btw, so here it is again. > > Hmm... On the other hand, it definitely needs at least _bh now... > I've tried this patch. There are lots of "Transmit timed out", but no > crashes.
ACK. Looks like you guys tracked down the crashing and fixed it (thanks!). I suspect we shouldn't have to reset due to timeouts that often, but that's another story.
Roger
| |