lkml.org 
[lkml]   [2009]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 02/12]posix_acl: Add the check items
On Tue, Dec 22, 2009 at 10:31:38PM +0800, liu weni wrote:
> Hi All:
>
> I'm sorry for my stupid. I am crazy for fixing this bug.
> And make so much mistake.

Welcome to the club. It's OK, _everyone_ around here had done that.
Many times.

> Maybe I need cool down and think more.

Always a good advice, but in this case it's a bit more specific - if you
see that you are modifying behaviour for some arguments, figure out what
would lead to such arguments and see if that behaviour is intentional ;-)
And if after that you are still not sure whether it's a bug or not, ask the
people involved what the hell had they intended to happen in such-and-such
case (often enough that'll bring variants of "nice catch" - bugs *do* happen).


\
 
 \ /
  Last update: 2009-12-22 15:51    [W:0.025 / U:2.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site