Messages in this thread | | | Date | Mon, 21 Dec 2009 08:43:44 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] gfs2: Use CALLER_ADDR0 macro. |
| |
On Mon, Dec 21, 2009 at 09:22:41AM +0000, Steven Whitehouse wrote: > Hi, > > Looks fairly harmless, even though I don't entirely see the point. Do > you want me to add this to me tree?
We also have a _RET_IP_ macro that does the same and has a much more useful name. And given that we need the address as void pointer to print it using our printk extension both seem a bit supoptimal.
Given that a lot of tracing code needs this a bit of standardization would be useful - more important for the type to store the address than just the macro name.
| |