Messages in this thread | | | Date | Tue, 22 Dec 2009 09:02:31 +0900 | From | Tejun Heo <> | Subject | Re: [this_cpu_xx V8 07/16] Module handling: Use this_cpu_xx to dynamically allocate counters |
| |
On 12/22/2009 08:28 AM, Rusty Russell wrote: > On Mon, 21 Dec 2009 06:29:36 pm Tejun Heo wrote: >> @@ -555,6 +556,7 @@ static void module_unload_free(struct module *mod) >> kfree(use); >> sysfs_remove_link(i->holders_dir, mod->name); >> /* There can be at most one match. */ >> + free_percpu(i->refptr); >> break; >> } >> } > > This looks very wrong.
Indeed, thanks for spotting it. Christoph, I'm rolling back all patches from this series. Please re-post with updates.
Thanks.
-- tejun
| |