Messages in this thread | | | Subject | Re: [Patch] thinkpad_acpi: fix a build error | From | Marcel Holtmann <> | Date | Mon, 21 Dec 2009 14:38:56 -0800 |
| |
Hi Henrique,
> > The patch isn't correct (I guess the upstream fix is same?). > > > > CONFIG_SOUND is a global config for sound subsystem. The relevant > > functions are ALSA core part, which is CONFIG_SND. > > So, the fix should be: > > > > depends on SND > > > > instead. > > Indeed. Ingo already fixed that too. > > Although I personally would prefer: > select SOUND > select SND > > But anything that stops the build errors will do for now.
I still haven't seen this patch in Linus' tree. And you do need select SOUND and SND. Otherwise you still get build errors. I have tested this on my machine. So can someone please submit a proper patch to get this fixed.
Regards
Marcel
| |