lkml.org 
[lkml]   [2009]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Patch] thinkpad_acpi: fix a build error
From
Date
Hi Henrique,

> > The patch isn't correct (I guess the upstream fix is same?).
> >
> > CONFIG_SOUND is a global config for sound subsystem. The relevant
> > functions are ALSA core part, which is CONFIG_SND.
> > So, the fix should be:
> >
> > depends on SND
> >
> > instead.
>
> Indeed. Ingo already fixed that too.
>
> Although I personally would prefer:
> select SOUND
> select SND
>
> But anything that stops the build errors will do for now.

I still haven't seen this patch in Linus' tree. And you do need select
SOUND and SND. Otherwise you still get build errors. I have tested this
on my machine. So can someone please submit a proper patch to get this
fixed.

Regards

Marcel




\
 
 \ /
  Last update: 2009-12-21 23:41    [W:0.118 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site