lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for December 19 (staging/dt3155)
On Sat, 19 Dec 2009 11:04:57 +1100 Stephen Rothwell wrote:

> Hi all,
>
> I said:
> > News: there will be no linux-next releases until at least Dec 24 and,
> > more likely, Dec 29. Have a Merry Christmas and take a break. :-)
>
> Well, I decided I had time for one more so it will be based in -rc1).
>
> This one has not had the build testing *between* merges, but has had all
> the normal build testing at the end. Since the latter testing showed no
> problems, this just means that there may be more unbisectable points in
> the tree (but that is unlikely).


When CONFIG_DT3155=y (i.e., not a loadable module):

(a)
drivers/staging/dt3155/dt3155_drv.c:967: error: implicit declaration of function 'pci_find_device'
drivers/staging/dt3155/dt3155_drv.c:1151: error: implicit declaration of function 'request_irq'
drivers/staging/dt3155/dt3155_drv.c:1152: error: 'IRQF_SHARED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1152: error: 'IRQF_DISABLED' undeclared (first use in this function)
drivers/staging/dt3155/dt3155_drv.c:1195: error: implicit declaration of function 'free_irq'


#ifdef MODULE
#include <linux/interrupt.h>

linux/interrupt.h is needed for DT3155=y, not just when DT3155=m.

Oh, and this config has: # CONFIG_PCI_LEGACY is not set
which accounts for pci_find_device() being unknown.
If that is required (as it is currently, even though this function is
deprecated), it can be expressed in the driver's Kconfig file:
depends on PCI_LEGACY



(b) when compiling goes further:

drivers/staging/dt3155/dt3155_drv.c:571: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
drivers/staging/dt3155/dt3155_drv.c:571: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
drivers/staging/dt3155/dt3155_drv.c:657: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
drivers/staging/dt3155/dt3155_drv.c:657: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'



General:

#ifndef CONFIG_PCI
#error "DT3155 : Kernel PCI support not enabled (DT3155 drive requires PCI)"
#endif

That should be handled via Kconfig, not in a .c file.
Ah, it is done in Kconfig, so those lines above (in .c file) can be deleted.


---
~Randy


\
 
 \ /
  Last update: 2009-12-19 04:15    [W:0.108 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site