Messages in this thread | | | Date | Fri, 18 Dec 2009 09:43:49 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars |
| |
On Fri, 18 Dec 2009, Paul Mundt wrote:
> On Thu, Dec 17, 2009 at 09:12:24PM -0800, Joe Perches wrote: > > On Thu, 2009-12-17 at 23:29 -0500, Valdis.Kletnieks@vt.edu wrote: > > > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- > > > continuation line, it's probably in its rights to whinge. > > > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more > > > produces a whole lot of "this can't end well" output. > > > > I think this is a good test to add to checkpatch. > > > > Add 105 character long line WARN test > > Add 80 character long line STRICT test > > Add 6+ leading indent tabs test, consider restructuring > > > This looks like a reasonable compromise.
I like this. Except I think the indent test should count spaces too some way. Or do we already warn about excessive space that should be tabs?
Linus
| |