Messages in this thread | | | Date | Fri, 18 Dec 2009 10:24:51 -0600 | From | Nathan Fontenot <> | Subject | Re: [PATCH 5/6 v5] CPU probe/release files |
| |
Andreas Schwab wrote: > Nathan Fontenot <nfont@austin.ibm.com> writes: > >> Index: powerpc/arch/powerpc/Kconfig >> =================================================================== >> --- powerpc.orig/arch/powerpc/Kconfig 2009-10-28 15:21:47.000000000 -0500 >> +++ powerpc/arch/powerpc/Kconfig 2009-10-28 15:21:53.000000000 -0500 >> @@ -320,6 +320,10 @@ >> >> Say N if you are unsure. >> >> +config ARCH_CPU_PROBE_RELEASE >> + def_bool y >> + depends on HOTPLUG_CPU >> + > > That does not work. > > drivers/built-in.o: In function `.store_online': > cpu.c:(.ref.text+0xf5c): undefined reference to `.cpu_hotplug_driver_lock' > cpu.c:(.ref.text+0xfc8): undefined reference to `.cpu_hotplug_driver_unlock' > make: *** [.tmp_vmlinux1] Error 1 > > cpu_hotplug_driver_lock is only defined on pseries, but HOTPLUG_CPU is > also defined on pmac.
These two routines should be defined as a no-op if CONFIG_ARCH_CPU_PROBE_RELEASE is not defined in linux/cpu.h. The update below should be in the patch set you are looking at.
from linux/cpu.h:
#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE extern void cpu_hotplug_driver_lock(void); extern void cpu_hotplug_driver_unlock(void); #else static inline void cpu_hotplug_driver_lock(void) { }
static inline void cpu_hotplug_driver_unlock(void) { } #endif
-Nathan Fontenot
| |