Messages in this thread | | | Date | Fri, 18 Dec 2009 10:32:23 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH x86/urgent] x86: Fix objdump version check in chkobjdump.awk for different formats. |
| |
Masami Hiramatsu wrote: > Different version of objdump says its version in different way; > > GNU objdump 2.16.1 > > or > > GNU objdump version 2.19.51.0.14-1.fc11 20090722 > > This patch uses the first argument which starts with a number > as version string. > > Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> > Suggested-by: H. Peter Anvin <hpa@zytor.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > > arch/x86/tools/chkobjdump.awk | 16 +++++++++++++--- > 1 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk > index 5bbb5a3..250dc79 100644 > --- a/arch/x86/tools/chkobjdump.awk > +++ b/arch/x86/tools/chkobjdump.awk > @@ -8,14 +8,24 @@ BEGIN { > od_sver = 19; > } > > -/^GNU/ { > - split($3, ver, "."); > +/^GNU objdump/ { > + verstr = "" > + for (i = 3; i <= NF; i++) > + if (match($(i), "^[0-9]")) { > + verstr = $(i++); ^^^^oops, it's not needed!
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |