Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] thermal: Fix test of unsigned in thermal_cooling_device_cur_state_store() | From | Zhang Rui <> | Date | Wed, 16 Dec 2009 09:05:16 +0800 |
| |
On Wed, 2009-12-16 at 05:46 +0800, Roel Kluin wrote: > state is unsigned long so the test did not work. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
> --- > Found using coccinelle: http://coccinelle.lip6.fr/ > > Is this the best way to fix this? > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 6f8d8f9..800e0c5 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -374,7 +374,7 @@ thermal_cooling_device_cur_state_store(struct device *dev, > if (!sscanf(buf, "%ld\n", &state)) > return -EINVAL; > > - if (state < 0) > + if ((long)state < 0) > return -EINVAL; > > result = cdev->ops->set_cur_state(cdev, state);
| ![\](/images/icornerr.gif) |