Messages in this thread | | | Date | Tue, 15 Dec 2009 21:44:57 +0100 | From | Pavel Machek <> | Subject | Re: GPIO support for HTC Dream |
| |
On Wed 2009-12-16 09:24:21, Ryan Mallon wrote: > Pavel Machek wrote: > > Hi! > > > >>> +int gpio_to_irq(unsigned gpio) > >>> +{ > >>> + return -EINVAL; > >>> +} > >> This should probably just be an inline function in > >> arch/arm/mach-msm/include/mach/gpio.h > > > > Well, it is not performance critical in any way and it is likely to > > change in future. I'd leave it here. > > If this function eventually does do something interesting, it would be > useful to have it as a macro in arch/arm/mach-msm/include/mach/gpio.h > since it can be used for static/define declarations, ie: > > #define SOME_GPIO_IRQ gpio_to_irq(SOME_GPIO)
gpio_to_irq is defined as a function in Doc*/gpio.txt.
> >> static inline int irq_to_gpio(unsigned irq) > >> { > >> return -EINVAL; > >> } > > > > I'd say that would be overdoing it. > > You should implement this if you have gpio_to_irq because it is part of > the API, see include/linux/gpio.h
I'm implementing it. I just don't want to implement two inline functions instead of one normal function. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |