lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] fs: fix compat_ioctl build for CONFIG_BLOCK=n
On Mon, 14 Dec 2009 20:16:13 +0000 Arnd Bergmann wrote:

> On Monday 14 December 2009 17:10:05 Randy Dunlap wrote:
> >
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > Fix build failure when CONFIG_BLOCK=n:
> >
> > fs/compat_ioctl.c:1604: error: 'SG_SET_TRANSFORM' undeclared
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Your patch is obviously correct, but I wonder if we could just drop
> the line completely, given that no driver in the kernel actually
> implements this ioctl command. It was part of the ide-scsi driver
> until 2.6.28, but that driver was removed in 2.6.29.

I checked with Jens, he says yes, drop that case.
Do you want to do that or should I send another patch?

thanks,
---
~Randy


\
 
 \ /
  Last update: 2009-12-15 20:33    [W:0.572 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site