lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] move eject code from zd1211rw to usb-storage
    Hi,

    On Tue, 15 Dec 2009 13:31:13 +0100
    Josua Dietze <digidietze@draisberghof.de> wrote:

    > Stefan Seyfried schrieb:
    >
    > > The USB ID claimed by zd1211rw for the fake storage device is
    > > also in use by other, non-zd1211rw devices (Sphairon Homelink
    > > 1202). Move the eject of these devices to where it belongs and
    > > where all the needed infrastructure already exists: usb-storage.
    >
    > We can do the eject (as other mode switches) in userspace. Previous
    > discussions pointed into that direction.

    Well, the zd1211rw already did that, I wanted to fix that up and was
    told to do it in usb-storage instead (which, looking at the diffstat,
    seems like a good idea).

    > And there is always the question of being able to access the "fake
    > CD-ROM" without hacking the kernel.

    I was thinking that I would be able to achieve that by echoing an
    appropriate quirk into /sys/module/usb-storage/parameters/quirks,
    however, I could not get it to *not* eject the device.
    But given that there is already an "option_zero_cd" parameter in
    usb-storage, it should be easy to massage this into a general "do not
    eject virtual installer media" flag so that people are still able to
    get the windows driver files off their devices should they need to do
    so.

    > I'd like to see these devices removed from unusual_devs.h.

    I'd like them to work with one driver, not two (one in kernel and one
    in userspace).

    That's a fundamental difference in opinions, and I fear I'm not the one
    who is going to decice how this will be handled ;)

    Have fun,

    Stefan
    --
    Stefan Seyfried

    "Any ideas, John?"
    "Well, surrounding them's out."


    \
     
     \ /
      Last update: 2009-12-15 15:03    [W:2.282 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site