Messages in this thread | | | From | Holger Schurig <> | Subject | Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs | Date | Tue, 15 Dec 2009 11:30:58 +0100 |
| |
> drivers/net/wireless/libertas$ grep lbs_deb_ * | grep ssid > |grep '%s' > assoc.c: lbs_deb_join("current SSID '%s', ssid length %u\n", > assoc.c: lbs_deb_join("requested ssid '%s', ssid length %u\n", > assoc.c: lbs_deb_join("ADHOC_START: SSID '%s', ssid > length %u\n", > scan.c: lbs_deb_wext("set_scan, essid '%s'\n",
All those lines are gone once my cfg80211 lands.
Do you know any way to make sparse moan about them?
BTW: the libertas firmware sometimes treat an SSID as a zero-terminated string. There are some firmware commands that accept just an u8[32] bytes for the SSID, but not an ssid_len, e.g. in the CMD_802_11_AD_HOC_START command.
You therefore can't connect to the otherwise legitimate SSID of TEST\0\0\0.
-- http://www.holgerschurig.de
| |