Messages in this thread Patch in this message | | | From | Frederic Weisbecker <> | Subject | [PATCH 13/13] ksym_tracer: Fix compile warnings | Date | Sun, 13 Dec 2009 14:08:14 +0100 |
| |
From: Li Zefan <lizf@cn.fujitsu.com>
Fix these 2 warnings:
kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_read': kernel/trace/trace_ksym.c:239: warning: cast to pointer from integer of different size kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_write': kernel/trace/trace_ksym.c:295: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Acked-by: Steven Rostedt <rostedt@goodmis.org> Cc: "K.Prasad" <prasad@linux.vnet.ibm.com> LKML-Reference: <4B1DC578.9020909@cn.fujitsu.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- kernel/trace/trace_ksym.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_ksym.c b/kernel/trace/trace_ksym.c index ddfa0fd..e7a8995 100644 --- a/kernel/trace/trace_ksym.c +++ b/kernel/trace/trace_ksym.c @@ -235,7 +235,8 @@ static ssize_t ksym_trace_filter_read(struct file *filp, char __user *ubuf, mutex_lock(&ksym_tracer_mutex); hlist_for_each_entry(entry, node, &ksym_filter_head, ksym_hlist) { - ret = trace_seq_printf(s, "%pS:", (void *)entry->attr.bp_addr); + ret = trace_seq_printf(s, "%pS:", + (void *)(unsigned long)entry->attr.bp_addr); if (entry->attr.bp_type == HW_BREAKPOINT_R) ret = trace_seq_puts(s, "r--\n"); else if (entry->attr.bp_type == HW_BREAKPOINT_W) @@ -277,7 +278,7 @@ static ssize_t ksym_trace_filter_write(struct file *file, { struct trace_ksym *entry; struct hlist_node *node; - char *input_string, *ksymname = NULL; + char *input_string, *buf, *ksymname = NULL; unsigned long ksym_addr = 0; int ret, op, changed = 0; @@ -291,7 +292,7 @@ static ssize_t ksym_trace_filter_write(struct file *file, } input_string[count] = '\0'; - strstrip(input_string); + buf = strstrip(input_string); /* * Clear all breakpoints if: @@ -299,14 +300,14 @@ static ssize_t ksym_trace_filter_write(struct file *file, * 2: echo 0 > ksym_trace_filter * 3: echo "*:---" > ksym_trace_filter */ - if (!input_string[0] || !strcmp(input_string, "0") || - !strcmp(input_string, "*:---")) { + if (!buf[0] || !strcmp(buf, "0") || + !strcmp(buf, "*:---")) { __ksym_trace_reset(); kfree(input_string); return count; } - ret = op = parse_ksym_trace_str(input_string, &ksymname, &ksym_addr); + ret = op = parse_ksym_trace_str(buf, &ksymname, &ksym_addr); if (ret < 0) { kfree(input_string); return ret; -- 1.6.2.3
| |