lkml.org 
[lkml]   [2009]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kfifo: fix warn_unused_result
> The rest of the patch seems to be adding BUG()s if kfifo_in() fails. 
> All over the place.
>
> If that's the appropriate way to handle failure for these callsites
> then it would be neater to do this in the callee. ie, add a new

BUG_ON is a bit extreme for most of those if they fail. WARN_ONCE perhaps
given the usual consequences are minor (eg pointer jumping)



\
 
 \ /
  Last update: 2009-12-14 01:53    [W:0.042 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site