Messages in this thread | | | Date | Sun, 13 Dec 2009 21:05:09 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 4/4] regulator: mc13783 change to platform_driver_register. |
| |
Hello,
On Sat, Dec 12, 2009 at 06:06:17PM +0100, Alberto Panizzo wrote: > Change the instant when regulator driver is probed. > To have a correct regulators initialisation (enable, disable and voltages > selection), the driver must have access to mc13783 registers and so > mc13783-core must be loaded before this. > > With this patch mc13783_regulator_probe is called when mc13783-core > register the regulator subsystem. > > Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com> I think the change is OK, the commit log isn't optimal though.
You might want to point out that the problem only occurs if the driver is built-in and that mc13783_regulator_probe doesn't need to be changed as it already lives in .devinit.text
As if mc13783-regulator is built-in mc13783-core is built-in, too, the wording isn't good. The problem is (I suppose) that regulators are linked first and so mc13783-core isn't *probed* early enough and so the mc13783-regulator device isn't available at mc13783-regulator probing time.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |