lkml.org 
[lkml]   [2009]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/9] drivers/video: Correct code taking the size of a pointer
On Sun, 13 Dec 2009 13:52:59 +0100 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

> Hi Julia, Andrew,
>
> Julia Lawall schrieb:
> > From: Julia Lawall <julia@diku.dk>
> >
> > sizeof(viafb_gamma_table) is just the size of the pointer. This is changed
> > to the size used when calling kmalloc to initialize the pointer.
>
> this is the second patch addressing this issue ending up in my mailbox.
> At least this one is technically correct so feel free to upstream it.
> However I vote for removing this ioctl hell from viafb as most of them
> duplicate framebuffer functionality or have unknown (not clearly
> defined) functionality or at least solve a generic problem with a custom
> ioctl (which I consider bad). I had a patch ready to move this stuff to
> an extra file and print a warning that it is subject to be removed. I
> feel a bit uncomfortable about repairing broken stuff prior to removing it.
> Any comments on this subject?
>

I favour both repairing and removing broken stuff ;)

We may as well fix it if problems are known. Perhaps someone is
hitting the problem at runtime in an older kernel and needs a patch to
backport. Perhaps we later decide to revert the removal, thus
reinstating the known bug.



\
 
 \ /
  Last update: 2009-12-13 20:47    [W:0.038 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site