Messages in this thread | | | Date | Sat, 12 Dec 2009 18:11:43 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/4] mfd: mc13783: Take care of semantic inversion between read and write value of two bits in POWER_MISCELLANEUS register. |
| |
On Sat, Dec 12, 2009 at 05:48:43PM +0100, Alberto Panizzo wrote: > MC13783_REGCTRL_PWGTnSPIEN controls the states of the corresponding > PWGTn_DRV output. > Reading 1 on the corresponding bit mean that the output is enabled > Writing 1 on the corresponding bit disable that output!
> So, if not asked directly to modify those bits, write the inverted > value.
Some comments in the code explaining what's going on wouild help a lot - it's not going to be obvious to a reader why the code is doing this and may well confuse them.
| |