Messages in this thread | | | Date | Fri, 11 Dec 2009 17:02:54 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH 2/3 v2] sh: fix DMA driver's descriptor chaining and cookie assignment |
| |
On Thu, Dec 10, 2009 at 06:35:11PM +0100, Guennadi Liakhovetski wrote: > The SH DMA driver wrongly assigns negative cookies to transfer descriptors, > also, its chaining of partial descriptors is broken. The latter problem is > usually invisible, because maximum transfer size per chunk is 16M, but if you > artificially set this limit lower, the driver fails. Since cookies are also > used in chunk management, both these problems are fixed in one patch. As side > effects a possible memory leak, when descriptors are prepared, but not > submitted, and multiple races have also been fixed. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Looks good to me.
Acked-by: Paul Mundt <lethal@linux-sh.org>
| |