Messages in this thread | | | Date | Fri, 11 Dec 2009 18:25:01 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 61/7] x86/pci: add cap_4g |
| |
On 12/11/2009 06:20 PM, Yinghai Lu wrote: >> >> How about: >> >> static inline resource_size_t cap_resource(u64 val) >> { >> if (val > ~(resource_size_t)0) >> return ~(resource_size_t)0; >> else >> return val; >> } > > ok
Stylisically I guess the idiom:
(resource_size_t)~0
... is better, not that it matters in this case, but the (type)~0 idiom gets the correct answer even when sizeof(type) < sizeof(int).
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |