Messages in this thread | | | Date | Fri, 11 Dec 2009 23:28:38 +0000 | From | Russell King - ARM Linux <> | Subject | Re: GPIO support for HTC Dream |
| |
On Fri, Dec 11, 2009 at 11:10:15PM +0100, Pavel Machek wrote: > +#include <linux/gpio.h> ... > +#include <mach/gpio.h> ... > +#include <asm/gpio.h>
Emm, this is getting really silly.
include/linux/gpio.h:
#ifdef CONFIG_GENERIC_GPIO #include <asm/gpio.h> #else ... #endif
arch/arm/include/asm/gpio.h:
#include <mach/gpio.h>
There really is no point in including mach/gpio.h nor asm/gpio.h when linux/gpio.h will do. I'm retiscent to add #warnings or #errors into these files, but it seems that this is such a common thing that it may be beneficial to do so.
| |