Messages in this thread | | | Subject | Re: dynamic ftrace - graph | From | Steven Rostedt <> | Date | Fri, 11 Dec 2009 09:37:35 -0500 |
| |
On Fri, 2009-12-11 at 08:29 +0100, Michal Simek wrote: > Steven Rostedt wrote: > > Hi Michal, > > > > Sorry for such a late reply, you sent this email to me at the worst > > time. My wife was having shoulder surgery and I heading for a > > conference. I fell very far behind in email and I only now just noticed > > this. > > No problem. I prepared Microblaze ftrace patches. You can find them in > linux-next. I am going to send pull request to Linus soon that's why if > you have any your comments please let me know. >
Hey, if they work and they are only in your arch, then I'm fine with them ;-)
> > > > > > I'll answer these ever though you may already figured it out. > > > > On Mon, 2009-11-09 at 17:52 +0100, Michal Simek wrote: > >> Hi Steve and others, > >> > >> I have working dynamic ftrace function. :-) > >> > >> I look at __ftrace_modify_code function and I have one question about. > >> Below are function which are called when I enable function_graph. > >> > >> I personally think that make more sense to call > >> ftrace_enable_ftrace_graph_caller before ftrace_update_ftrace_func. > >> The reason for it is that graph_caller enable calling graph tracing > >> which should be setup before ftrace_update_ftrace_func which enable > >> whole tracing function. > > > > Have you seen any difference in output with this? > > I haven't tested it. It was just suggestion. I don't know if is relevant > or not.
I'm not sure it is relevant. Those are enabled in stop_machine so the only thing you would be missing is the tracer enabling itself.
-- Steve
| |