Messages in this thread | | | Date | Fri, 11 Dec 2009 08:48:12 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone |
| |
On 12/11/2009 07:07 AM, Larry Woodman wrote: > Minchan Kim wrote: >> >> I like this. but why do you select default value as constant 8? >> Do you have any reason? >> >> I think it would be better to select the number proportional to NR_CPU. >> ex) NR_CPU * 2 or something. >> >> Otherwise looks good to me. >> >> Reviewed-by: Minchan Kim <minchan.kim@gmail.com> >> > This is a per-zone count so perhaps a reasonable default is the number > of CPUs on the > NUMA node that the zone resides on ?
One reason I made it tunable is so people can easily test what a good value would be :)
-- All rights reversed.
| |