lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Return value of print_graph_prologue
On Fri, Dec 11, 2009 at 06:12:31PM +0800, Wenji Huang wrote:
> Hi,
>
> I got confused about the return value of print_graph_prologue. See:
>
> 805 /* Latency format */
> 806 if (trace_flags & TRACE_ITER_LATENCY_FMT) {
> 807 ret = print_graph_lat_fmt(s, ent);
> 808 if (ret == TRACE_TYPE_PARTIAL_LINE)
> 809 return TRACE_TYPE_PARTIAL_LINE;
> 810 }
> 811
> 812 return 0;
> 813 }
>
> But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's
> no difference between success and failure?
>
> Should it be TRACE_TYPE_HANDLED ?
>
> Regards,
> Wenji


Oh, good catch, I'm preparing a fix.

Thanks.



\
 
 \ /
  Last update: 2009-12-11 12:07    [W:0.041 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site