Messages in this thread Patch in this message | | | Subject | [PATCH 1/5] Fix dubious bitwise 'or' usage spotted by sparse. | From | Alexey Zaytsev <> | Date | Sat, 10 Jan 2009 02:47:57 +0300 |
| |
It doesn't change the semantics, but it looks like the logical 'or' was meant to be used here.
Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com> --- mm/page_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d8ac014..6923237 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -306,7 +306,7 @@ static void destroy_compound_page(struct page *page, unsigned long order) for (i = 1; i < nr_pages; i++) { struct page *p = page + i; - if (unlikely(!PageTail(p) | + if (unlikely(!PageTail(p) || (p->first_page != page))) bad_page(page); __ClearPageTail(p);
| |