lkml.org 
[lkml]   [2009]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Fix leap second message hang
From
Date
On Fri, 2009-01-09 at 14:31 -0600, Chris Adams wrote:
> Resending this outside the big long thread to make sure it gets added
> (it isn't critical right now but I don't want to forget it).

Best way to get stuff added is to CC the right people -- loose patches
get lost easily.

> The code to handle leap seconds printks an information message when the
> second is inserted or deleted. It does this while holding xtime_lock.
> However, printk wakes up klogd, and in some cases, the scheduler tries
> to get the current kernel time, trying to get xtime_lock (which results
> in a deadlock). This moved the printks outside of the lock. It also
> adds a comment to not use printk while holding xtime_lock.

That should actually work these days, we don't actually do a direct wake
up anymore.

printk should work from all places, including holding rq->lock and
xtime_lock.


\
 
 \ /
  Last update: 2009-01-09 22:51    [W:0.081 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site